docs(factories): add automation filters page - #551
Conversation
Add a shared reference for automation filter matching rules, per-source filter availability, the routing-vs-access boundary, and filters in definitions as code. Link it from the Slack and Jira integration pages and the Factories sidebar. Co-Authored-By: Warp <agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This PR was generated with Warp. Comment |
|
Your Warp account is not a member of any team with access to this repository. |
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
…ories-automation-filters # Conflicts: # src/content/docs/factories/integrations/slack.mdx
There was a problem hiding this comment.
Overview
This PR adds a dedicated factory automation filters page, links it from the Slack and Jira factory integration pages, and adds the page to the factories sidebar. The changed docs are consistent with the repository style guidance, the added MDX comment matches existing source-comment practice, and the diff does not introduce security-sensitive code or configuration.
Concerns
- None.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Align the new automation-filters page and its jira.mdx cross-link with the root-absolute link convention adopted on hyc/factory-launch in #550. Co-Authored-By: Warp <agent@warp.dev>
|
Resolved the merge conflict with
Validation: |
… and cross-page seams (#557) * docs(factories): convert relative links to root-absolute on launch pages Relative links resolve against the page's trailing-slash URL at runtime (./x becomes /factories/<page>/x), so they 404 even though the file-based CI link checker passes. #550 swept the pages merged before it; the pages that landed after (#516 overview/how-it-works, #520 connect, #527 Linear) reintroduced the pattern. Converts all of them to the repo's root-absolute trailing-slash convention. Co-Authored-By: Warp <agent@warp.dev> * docs(factories): fix cross-page seams left by the stacked launch PRs - Map the setup wizard's Code toggle to the Implement role (quickstart vs factory-agents used different names for the same role) - Map lifecycle stage names to the Activity view's UI names (Planning, Building), which how-factories-work never connected - Define a Factory MCP task as the factory's work item; the page used 'task' throughout without bridging to the term the rest of the section uses - Link connect-your-factory to the automation-filters page (#551 added the page after #520 merged, so the hub never referenced it) - Align 'cancelled' spelling on the Jira page with the rest of the section - Replace two 'cloud agent identity' usages with 'cloud agent' per the terminology glossary (platform/agents.mdx) Co-Authored-By: Warp <agent@warp.dev> --------- Co-authored-by: Warp <agent@warp.dev>


Summary
Adds
factories/automation-filters— the dedicated filters page requested in advait's review comment on #520. Filter behavior was previously scattered across seven pages in the launch stack with the matching semantics stated only on the Linear page and the routing-vs-access caveat repeated on five pages. This page consolidates:filterkey ontriggers, reusing the verified example from the definitions-as-code page.Also links to the new page from the two integration pages already merged into
hyc/factory-launch(Slack authorization paragraph, Jira filter section) and adds the sidebar entry under Connect.Dependencies and follow-ups
hyc/factory-launch: it links only pages that exist on the branch (Slack, GitHub, Linear, Jira placeholders, factory-as-code, control room).factories/integrations/gitlabdoesn't exist on the branch until docs(factories): document GitLab integration #549 lands; an inline MDX TODO marks the one-line follow-up. If docs(factories): document GitLab integration #549 merges first, I can link it here instead.Validation
npm run typecheck: 0 errorsnpm run build: 378 pages built (377 + this page); table renders, all internal links resolve, and the Slack/Jira pages link backstyle_lint --changed: 0 issues in the new page; remaining flags are pre-existing warnings on untouched linesUnverified claims
None introduced against product source directly — every behavior claim is consolidated verbatim-or-tighter from launch-stack pages that were themselves verified against source (Warp
e72fd7aac, warp-server9be39e484bper #520/#525/#528): matching semantics from the Linear (#527) and Jira pages, filter tables from the GitHub (#526) and GitLab (#549) pages, who-can-start-work from the GitHub/GitLab/Slack pages, the editor procedure from the Slack/GitHub pages, and the YAML example from the definitions-as-code page (#519).